Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version in docker pull #2919

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Update version in docker pull #2919

merged 2 commits into from
Dec 16, 2024

Conversation

lucacome
Copy link
Member

Proposed changes

Wrong version in the docker pull

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested review from a team as code owners December 16, 2024 21:17
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 16, 2024
@sjberman
Copy link
Contributor

Seems that our workflow for the release PR is missing multiple docs now...

@lucacome
Copy link
Member Author

yeah it's kinda weird

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.59%. Comparing base (7b60982) to head (8e13aaa).
Report is 1 commits behind head on release-1.5.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.5    #2919      +/-   ##
===============================================
- Coverage        89.71%   89.59%   -0.12%     
===============================================
  Files              109      108       -1     
  Lines            11091    10862     -229     
  Branches            50        0      -50     
===============================================
- Hits              9950     9732     -218     
+ Misses            1082     1071      -11     
  Partials            59       59              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome merged commit 5d1350b into nginx:release-1.5 Dec 16, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants