fix(github): published broken links (#269)

ngVenezuela · Aug 11, 2020 · 9ccc2f0 · 9ccc2f0
1 parent 36d2312
commit 9ccc2f0
Show file tree

Hide file tree

Showing 4 changed files with 51 additions and 35 deletions.
diff --git a/api/_utils/github/feed.ts b/api/_utils/github/feed.ts
@@ -11,13 +11,15 @@ interface RepoConfig {
 
 const handleGithubFeed = async (
   repoConfig: RepoConfig,
-  tags: string[],
+  urls: string[],
 ): Promise<void> => {
   if (MAIN_GROUP_ID) {
     const promises: Promise<void>[] = [];
     const repoMainUrl = repoConfig.feed.replace('releases.atom', '');
 
-    tags.forEach(tag => {
+    urls.forEach(url => {
+      const tag = url.match(/[\w.-]+$/gi)![0];
+
       const promise = sendMessage({
         chatId: Number(MAIN_GROUP_ID),
         text: messages.githubRelease
@@ -27,7 +29,7 @@ const handleGithubFeed = async (
             '#{url}',
             repoConfig.hasChangelog
               ? `${repoMainUrl}blob/master/CHANGELOG.md`
-              : `https://github.com/${repoConfig.name}/releases/tag/${tag}`,
+              : url,
           ),
       });
 

diff --git a/api/superfeedr/index.ts b/api/superfeedr/index.ts
@@ -14,7 +14,7 @@ Sentry.init({ dsn: SENTRY_DSN });
 
 // Taken from https://documentation.superfeedr.com/schema.html
 interface Item {
-  title: string;
+  permalinkUrl: string;
 }
 
 /**
@@ -56,12 +56,12 @@ export default async (request: NowRequest, response: NowResponse) => {
           const repoConfig = config.githubFeeds.find(
             ({ feed }) => feed === updatedFeed,
           );
-          const tags = request.body.items.map(
-            (item: Item) => item.title,
+          const urls = request.body.items.map(
+            (item: Item) => item.permalinkUrl,
           );
 
           if (repoConfig) {
-            await handleGithubFeed(repoConfig, tags);
+            await handleGithubFeed(repoConfig, urls);
           }
         } else {
           // If it isn't a github feed, it's a blog feed

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -33,10 +33,11 @@
     "twitter-autohook": "^1.7.2"
   },
   "devDependencies": {
+    "@semantic-release/changelog": "^5.0.1",
     "@types/node": "^14.0.27",
     "@types/node-fetch": "^2.5.7",
-    "@typescript-eslint/eslint-plugin": "^3.8.0",
-    "@typescript-eslint/parser": "^3.8.0",
+    "@typescript-eslint/eslint-plugin": "^3.9.0",
+    "@typescript-eslint/parser": "^3.9.0",
     "eslint": "^7.6.0",
     "eslint-config-prettier": "^6.11.0",
     "eslint-plugin-prettier": "^3.1.4",
@@ -77,6 +78,7 @@
         }
       ],
       "@semantic-release/release-notes-generator",
+      "@semantic-release/changelog",
       "@semantic-release/github"
     ]
   }