Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme:default): fix inconsistency of top icon size #1841

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Oct 11, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@cipchk
Copy link
Member Author

cipchk commented Oct 11, 2024

Preview is ready!

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.87%. Comparing base (811095b) to head (c7cd16c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1841    +/-   ##
========================================
  Coverage   94.87%   94.87%            
========================================
  Files         315      315            
  Lines        8931     8931            
  Branches     1800     1699   -101     
========================================
  Hits         8473     8473            
  Misses        382      382            
  Partials       76       76            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cipchk cipchk merged commit 27ff917 into master Oct 13, 2024
9 checks passed
@cipchk cipchk deleted the issues-2519 branch October 13, 2024 17:12
@zengqinglei
Copy link

我检查了预览界面,大小仍然不一致;
同时我也查看了你们提交的源码,发现应该是针对这个是无效的,麻烦在确认下:
image

@cipchk
Copy link
Member Author

cipchk commented Oct 14, 2024

针对这个 PR 的预览应该是 https://preview-1841-ng-alain-delon.surge.sh/dev/home

png:

QQ_1728919389512

@zengqinglei
Copy link

@cipchk
Accepted, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

顶部菜单折叠开关html标签使用与其他功能按钮不一致,导致图标大小不协调
3 participants