Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(acl): remove forRoot #1690

Merged
merged 2 commits into from
Nov 10, 2023
Merged

feat(acl): remove forRoot #1690

merged 2 commits into from
Nov 10, 2023

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Nov 10, 2023

BREAKING CHANGE: 提升 ACLServiceACLGuardServiceroot 就无须再依赖 forRoot,事实上 root 当未使用时是不影响摇树

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

BREAKING CHANGE: 提升 `ACLService`,`ACLGuardService` 为 `root` 就无须再依赖 `forRoot`,事实上 `root` 当未使用时是不影响摇树
@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Nov 10, 2023

Preview is ready!

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #1690 (a26c527) into master (b9e0fad) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head a26c527 differs from pull request most recent head 2b9354b. Consider uploading reports for the commit 2b9354b to get more accurate results

@@            Coverage Diff             @@
##           master    #1690      +/-   ##
==========================================
- Coverage   95.53%   95.52%   -0.02%     
==========================================
  Files         300      300              
  Lines        8830     8828       -2     
  Branches     1659     1659              
==========================================
- Hits         8436     8433       -3     
  Misses        325      325              
- Partials       69       70       +1     
Files Coverage Δ
packages/acl/src/acl-guard.ts 100.00% <ø> (ø)
packages/acl/src/acl-if.directive.ts 100.00% <ø> (ø)
packages/acl/src/acl.directive.ts 100.00% <ø> (ø)
packages/acl/src/acl.module.ts 100.00% <100.00%> (ø)
packages/acl/src/acl.service.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@cipchk cipchk merged commit 4472d48 into master Nov 10, 2023
8 checks passed
@cipchk cipchk deleted the feat-provide-acl branch November 10, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants