fix(theme:title): fix ignore empty title (#1638)

ng-alain · Aug 5, 2023 · c7bf339 · c7bf339
1 parent d815dbd
commit c7bf339
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/packages/theme/src/services/title/title.service.spec.ts b/packages/theme/src/services/title/title.service.spec.ts
@@ -75,6 +75,14 @@ describe('Service: Title', () => {
       expect(title.setTitle).toHaveBeenCalledWith(`${notPageName} - ${alain}`);
     }));
 
+    it('should be ignore when empty title & default title', fakeAsync(() => {
+      srv.default = '';
+      srv.suffix = alain;
+      srv.setTitle();
+      tick(srv.DELAY_TIME + 1);
+      expect(title.setTitle).toHaveBeenCalledWith(`${alain}`);
+    }));
+
     it('should set new title', fakeAsync(() => {
       srv.suffix = alain;
       srv.setTitle('newTitle');

diff --git a/packages/theme/src/services/title/title.service.ts b/packages/theme/src/services/title/title.service.ts
@@ -146,7 +146,7 @@ export class TitleService implements OnDestroy {
         if (this._prefix) {
           newTitles.push(this._prefix);
         }
-        newTitles.push(...(titles as string[]));
+        newTitles.push(...titles.filter(title => !!title));
         if (this._suffix) {
           newTitles.push(this._suffix);
         }