Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport support for Graviton 4 to version 3.16.1 #1414

Merged
merged 21 commits into from
Oct 22, 2024

Conversation

pabloaledo
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nf-core-bot
Copy link
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 2.14.1.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@drpatelh drpatelh changed the title Dev Backport support for Graviton 4 to version 3.16.1 Oct 16, 2024
nextflow.config Outdated
@@ -123,7 +123,7 @@ params {

// Max resource options
// Defaults only, expecting to be overwritten
max_memory = '128.GB'
max_memory = '256.GB'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we revert this change too @pabloaledo ? Shouldn't make a difference setting this higher.

workflows/rnaseq/main.nf Outdated Show resolved Hide resolved
@pditommaso
Copy link
Contributor

@drpatelh is there already an upstream PR for this? I mean merging the branch nf-core:arm_3.16.1 to the main/dev one?

@pinin4fjords
Copy link
Member

@pditommaso not yet- I'm basically working to cut down what's necessary here. Almost done.

@pinin4fjords pinin4fjords merged commit 56f1a47 into nf-core:arm_3.16.1 Oct 22, 2024
24 of 28 checks passed
@pinin4fjords
Copy link
Member

#1425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants