-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nf-tests and language server fixes #153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Small suggestions to document the reason for the changes in the PR.
- Add information to changelog.
- Test (and post results) of the full chromosome test before the full test.
subworkflows/local/utils_nfcore_phaseimpute_pipeline/tests/function.nf.test.snap
Outdated
Show resolved
Hide resolved
2754567
to
ca6c5a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. There’s a lot of great work in here. I noticed, though, that the scope of this PR is still a bit broad. Since the main focus is on "reducing computational time for the AWS megatest," could we keep this PR to just those specific changes? Some of the updates seem unrelated, and reviewing all 64 files at once makes it a bit tough to keep things focused.
Would you mind splitting out the unrelated changes into separate PRs (e.g. subworkflow snapshots, major language server fixes)? I'll make it better for me to give each code the attention it deserves. Also, include the results of at least one full chromosome test (you can run it on a large gitpod instance with a small sample and it shouldn't take that long) showing the performance improvement will be super helpful to speed up the review.
The scope of the PR has been changed to only fix the language server and nf-test updates. |
usage.md
.def
has been added when necesary, `use instead of
,` in assertions,_
added to variables not used in closures,for
loop replaced by.each{}
,PR checklist
nf-core pipelines lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).