Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add STIMULUS/CHECKTORCHMODEL #6898

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add STIMULUS/CHECKTORCHMODEL #6898

wants to merge 11 commits into from

Conversation

itrujnara
Copy link
Contributor

@itrujnara itrujnara commented Oct 29, 2024 •
edited
Loading

Closes #6872
Closes nf-core/deepmodeloptim#197

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

@itrujnara
Copy link
Contributor Author

The nf-test fails because the current version of the Python script expects a JSON and the test data is YAML. It will be fixed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessiovignoli alessiovignoli alessiovignoli left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new module: STIMULUS/CHECKTORCHMODEL Turn check_torch_model into an nf-core module
2 participants
@itrujnara @alessiovignoli