Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module muse/call #5630

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add module muse/call #5630

wants to merge 11 commits into from

Conversation

famosab
Copy link
Contributor

@famosab famosab commented May 17, 2024

PR checklist

Closes #5621

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

The Docker image still needs to be pushed to the nf-core registry, then I can update the paths accordingly. Also relates to #5629

@famosab famosab requested a review from a team as a code owner May 17, 2024 14:18
@famosab famosab requested review from koenbossers and removed request for a team May 17, 2024 14:18
@SPPearce
Copy link
Contributor

Could this tool be added to BioConda? Then the other containers would be generated automatically

@famosab
Copy link
Contributor Author

famosab commented May 21, 2024

I opened a PR: bioconda/bioconda-recipes#47957

If that works, I will change the files in this PR accordingly

@famosab famosab requested a review from a team as a code owner November 15, 2024 09:34
@famosab famosab changed the title Add module muse/call and Dockerfile Add module muse/call Nov 15, 2024
Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.

modules/nf-core/muse/call/main.nf Outdated Show resolved Hide resolved
modules/nf-core/muse/call/meta.yml Outdated Show resolved Hide resolved
description: |
Groovy Map containing sample information
e.g. `[ id:'sample1' ]`
- tumor_bam:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the tool use the indexes of the sorted bam files if they are present? If so, they should be passed in too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am not sure, from the tool description it seems that it takes care of this inside of the tool (tabix is one of the dependencies)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you ask the authors please? As often the tools assume that the index is next to the bam file, which will generally work fine with symlinks on a HPC system but isn't true for cloud execution.

e.g. `[ id:'test' ]`
- reference:
type: file
description: faidx indexed reference genome file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An indexed file? Does that mean it wants the index to be present alongside?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copied that from the module description but to me it seems that is also happy with just the fasta file

Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to check about the indexes (bam and fasta), but otherwise I'm happy.

description: |
Groovy Map containing sample information
e.g. `[ id:'sample1' ]`
- tumor_bam:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you ask the authors please? As often the tools assume that the index is next to the bam file, which will generally work fine with symlinks on a HPC system but isn't true for cloud execution.

@famosab
Copy link
Contributor Author

famosab commented Nov 18, 2024

I asked here: wwylab/MuSE#31
Will wait for their reply and merge afterwards :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

new module: MuSE
2 participants