-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module muse/call
#5630
base: master
Are you sure you want to change the base?
Add module muse/call
#5630
Conversation
Could this tool be added to BioConda? Then the other containers would be generated automatically |
I opened a PR: bioconda/bioconda-recipes#47957 If that works, I will change the files in this PR accordingly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments.
description: | | ||
Groovy Map containing sample information | ||
e.g. `[ id:'sample1' ]` | ||
- tumor_bam: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the tool use the indexes of the sorted bam files if they are present? If so, they should be passed in too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am not sure, from the tool description it seems that it takes care of this inside of the tool (tabix is one of the dependencies)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you ask the authors please? As often the tools assume that the index is next to the bam file, which will generally work fine with symlinks on a HPC system but isn't true for cloud execution.
e.g. `[ id:'test' ]` | ||
- reference: | ||
type: file | ||
description: faidx indexed reference genome file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An indexed file? Does that mean it wants the index to be present alongside?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just copied that from the module description but to me it seems that is also happy with just the fasta file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to check about the indexes (bam and fasta), but otherwise I'm happy.
description: | | ||
Groovy Map containing sample information | ||
e.g. `[ id:'sample1' ]` | ||
- tumor_bam: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you ask the authors please? As often the tools assume that the index is next to the bam file, which will generally work fine with symlinks on a HPC system but isn't true for cloud execution.
I asked here: wwylab/MuSE#31 |
PR checklist
Closes #5621
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda
The Docker image still needs to be pushed to the nf-core registry, then I can update the paths accordingly. Also relates to #5629