Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge template updates #300

Merged
merged 11 commits into from
Jan 4, 2024
Merged

Conversation

jonasscheid
Copy link
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mhcquant branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

github-actions bot commented Jan 3, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 0d00b14

+| ✅ 162 tests passed       |+
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in WorkflowMhcquant.groovy: Optionally add in-text citation tools to this list.
  • system_exit - System.exit in WorkflowMhcquant.groovy: System.exit(1) [line 18]
  • system_exit - System.exit in WorkflowMhcquant.groovy: System.exit(1) [line 45]
  • system_exit - System.exit in WorkflowMhcquant.groovy: System.exit(1) [line 51]
  • system_exit - System.exit in WorkflowMain.groovy: System.exit(1) [line 51]

✅ Tests passed:

Run details

  • nf-core/tools version 2.11.1
  • Run at 2024-01-04 12:32:50

Copy link
Contributor

@mapo9 mapo9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Minor changes maybe?

CHANGELOG.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mapo9 mapo9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@jonasscheid jonasscheid merged commit 35b0240 into nf-core:dev Jan 4, 2024
9 checks passed
@jonasscheid jonasscheid deleted the merge-template-updates branch January 4, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants