Final changes for release 2.5.0 #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mapo9
requested changes
Oct 9, 2023
mapo9
requested changes
Oct 9, 2023
mapo9
approved these changes
Oct 9, 2023
steffenlem
reviewed
Oct 10, 2023
Comment on lines
+39
to
+41
| ```tsv | ||
| ID Sample Condition ReplicateFileName | ||
| 1 msrun tumor /path/to/msrun.raw|mzML|d |
There was a problem hiding this comment.
You switched to tsv 😱 ?
There was a problem hiding this comment.
That was already implemented some releases ago.. (before my time 😄) Is there a csc standard I missed?
| @@ -56,21 +56,21 @@ workflow QUANT { | |||
| mzml, | |||
| merge_meta_map | |||
| ) | |||
| ch_versions = ch_versions.mix(MAP_ALIGNMENT.out.versions.ifEmpty(null)) | |||
| ch_versions = ch_versions.mix( MAP_ALIGNMENT.out.versions.ifEmpty(null) ) | |||
There was a problem hiding this comment.
is the ifEmpty really necessary?
There was a problem hiding this comment.
Probably not 🤔
| .join(OPENMS_IDMERGER_QUANT.out.idxml) | ||
| .join( MAP_ALIGNMENT.out.aligned_idxml ) | ||
| .map { meta, mzml, idxml -> [[id: meta.sample + '_' + meta.condition], meta, [id:meta.id, file:mzml], [id:meta.id, file:idxml]] } | ||
| .groupTuple( sort: sortById ) |
There was a problem hiding this comment.
it would be good to add the expected size here to prevent stalling (and with all groupTuples everywhere)
There was a problem hiding this comment.
How would I do that..?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporated suggestions for upcoming release
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).