-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add submitters to footer filters; #738
base: master
Are you sure you want to change the base?
Conversation
adds author,originating_lab,submitting_lab to footer filters for main nextstrain builds so that we can link to this instead of trying to find the submitters' handles on twitter.
Sorry, I think I'm behind on the history of this. I don't have anything against this as an idea - to point to instead of Twitter tagging - however, I'm concerned this will add a lot of length to the page - further burying the "downloads" link and the rest of our very bottom-of-page, behind huge blue-link walls of text. Can we maybe test this so we can see the damage this does in terms of page length & display? |
Yes, I was worried about that @emmahodcroft. Just ran a trial build to see how it looks: https://github.com/nextstrain/ncov/runs/3758690775?check_suite_focus=true |
Thanks Eli! Can you let me know where I look to see the output? I tried the URL in the build: https://nextstrain.org/staging/ncov/gisaid/trial/submitters-in-footer/ But couldn't seem to find anything. |
@emmahodcroft its here https://nextstrain.org/staging/ncov/open/trial/submitters-in-footer/global, that's my fault for not posting the link to begin with (I didn't know exactly where it would show up either)! Here is the format for finding these trial builds in the future: https://github.com/nextstrain/ncov/blob/a94f0cea349ce8e0c23eade4a4ff65cb081bf0e1/docs/dev_docs.md#triggering-trial-builds. |
Yeah that isn't the best-looking, I agree @emmahodcroft. One thing that would make it better is just being able to have that section collapsed by default (and expandable on click) as @jameshadfield has suggested. Otherwise your suggestion of linking to a separate file seems like a workable alternative. |
Collapsable filters would be a nice solution here and shouldn't be too difficult. Would pay dividends in a variety of circumstances. |
adds
author
,originating_lab
,submitting_lab
to footer filters for main nextstrain builds
so that we can link to this instead of trying
to find the submitters' handles on twitter.