Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Nextclade v3 #1160

Merged
merged 6 commits into from
Oct 30, 2024
Merged

Migrate to Nextclade v3 #1160

merged 6 commits into from
Oct 30, 2024

Commits on Oct 23, 2024

  1. nextstrain_profiles: Remove unused use_nextalign param

    The config param `use_nextalign` has not been used since
    <2839278>
    joverlee521 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    a2dfb6d View commit details
    Browse the repository at this point in the history
  2. Remove unused mutations summary rules & script

    This commit removes the rules `mutation_summary` and
    `build_mutation_summary`, both of which called the removed script
    `scripts/mutation_summary.py`.
    
    I was looking into updating the script to work with Nextclade v3 outputs
    but it seems like the rules using the script are not actively used in
    the Snakemake workflow!
    
    In Feb 2021, the script and rule `mutation_summary` were added and the
    only use of the output `results/mutation_summary_{origin}.tsv.xz`
    was to be uploaded it as an intermediate file of the builds.¹
    In Jan 2022, the upload of the intermediate file was removed² and I
    cannot find any other uses of the file so the rule `mutation_summary`
    seems unused.
    
    In March 2021, the rule `build_mutation_summary` was added to support
    the rule `add_mutation_counts`.³ However, `add_mutation_counts` was
    later updated to use `augur distance`⁴ which does not require the
    mutation summary output. I cannot find any other uses of the output file
    `results/{build_name}/mutation_summary.tsv`, so the rule
    `build_mutation_summary` seems unused.
    
    ¹ <#562>
    ² <#814>
    ³ <3b23e8f>
    ⁴ <d24d531>
    joverlee521 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    bd35325 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Remove unused outputs for align

    The only downstream use of the insertions and translations outputs of
    `align` rule was the `mutation_summary` rule which was removed in the
    previous commit.
    
    Even though this is no longer doing translations, we are still keeping
    the `annotation` config param and the `defaults/annotation.gff` file
    for codon-aware nucleotide alignment.
    <#1160 (comment)>
    joverlee521 committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    852eaf8 View commit details
    Browse the repository at this point in the history
  2. Migrate to Nextclade v3

    Major change includes the removal of the insertions.csv output from the
    `build_align` rule. This output was only used by the
    `build_mutation_summary` rule, which was removed in a previous commit.
    
    Note: Using `nextclade` instead of `nextclade3` to allow the workflow to
    continue to work with Snakemake's `--use-conda` interface.
    joverlee521 committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    8d80e6f View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Configuration menu
    Copy the full SHA
    ef94e27 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f269e69 View commit details
    Browse the repository at this point in the history