Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer any need to pin to an outdated edge version of Nextflow. #459

Closed
wants to merge 1 commit into from

Conversation

robsyme
Copy link
Contributor

@robsyme robsyme commented Nov 17, 2024

At present, the Dockerfile sets the NXF_VER and NXF_EDGE environment variables, which causes ugly message

Nextflow 24.09.2-edge is available - Please consider updating your version to it

For all runs. Unpinning these versions (and rebuilding the container) would remove these warnings.

Copy link

netlify bot commented Nov 17, 2024

Deploy Preview for nextflow-training ready!

Name Link
🔨 Latest commit da6c8e7
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-training/deploys/673a64ed75ef9700087934c4
😎 Deploy Preview https://deploy-preview-459--nextflow-training.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pinin4fjords
Copy link
Collaborator

We want to pin to a version though, right? Otherwise output could change wrt examples? The older docs even had a bit telling users to do the pinning as I recall, for that reason.

@robsyme
Copy link
Contributor Author

robsyme commented Nov 18, 2024

Do you mean output like:

 N E X T F L O W   ~  version 24.02.0-edge

 ┃ Launching `hello-genomics.nf` [special_goldstine] DSL2 - revision: 4cbbf6ea3e

executor >  local (6)
[d6/10c2c4] SAMTOOLS_INDEX (1)       | 3 of 3 ✔
[88/1783aa] GATK_HAPLOTYPECALLER (2) | 3 of 3 ✔

I would doubt that anybody would be too confused, but I'm happy to comprimise. I'm happy to pin, but would prefer that we pin to a stable release.

@robsyme
Copy link
Contributor Author

robsyme commented Nov 18, 2024

Closing in favor of #463

@robsyme robsyme closed this Nov 18, 2024
@pinin4fjords
Copy link
Collaborator

I mostly mean that we don't know how future versions of Nextflow might tweak the output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants