Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

add monochrome_logs and monochromeLogs to expected parameters #110

Merged
merged 1 commit into from
Oct 12, 2023
Merged

add monochrome_logs and monochromeLogs to expected parameters #110

merged 1 commit into from
Oct 12, 2023

Conversation

mirpedrol
Copy link
Collaborator

No description provided.

ewels
ewels approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Why both camelCase and snake_case?

@mirpedrol
Copy link
Collaborator Author

Why both camelCase and snake_case?

We discussed this in the PR with this feature.
It should be camelCase because it is a nextflow parameter. But we are using snake_case in nf-core also for other functionalities, so we would need to have both monochrome_logs and monochromeLogs in the template. Do you think it's too confusing?

nvnieuwk
nvnieuwk approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mirpedrol mirpedrol merged commit 357fc59 into nextflow-io:master Oct 12, 2023
3 checks passed
@mirpedrol mirpedrol deleted the expectedparameters branch October 12, 2023 08:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nvnieuwk nvnieuwk nvnieuwk approved these changes

@ewels ewels ewels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mirpedrol @ewels @nvnieuwk