Expand wrroc with fields needed for federated analysis #37
+599
−130
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,6 +23,12 @@ prov { | |
| wrroc { | ||
| file = "${params.outdir}/ro-crate-metadata.json" | ||
| overwrite = true | ||
| agent { | ||
| name = "John Doe" | ||
| orcid = "https://orcid.org/0000-0000-0000-0000" | ||
| } | ||
| license = "https://spdx.org/licenses/Apache-2.0" | ||
|
There was a problem hiding this comment. Can we not pull this information automatically from a There was a problem hiding this comment. This new output format for the nf-prov plugin creates RO-Crates that follow this profile. Similar to your previous review concerning the agent, the license is added directly to the RO-Crate. The crate will include input and output files, the pipeline configuration, and the pipeline itself. I will ensure that the |
||
| profile = "provenance_run_crate" | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can pull this information from the new
manifest.contributorsconfig scope now:https://www.nextflow.io/docs/latest/reference/config.html#config-manifest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new output format for the nf-prov plugin creates RO-Crates that follow this profile.
The agent mentioned in the config is not the persons who wrote the workflow, but the person who runs the workflow.