-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(README): Expand details for devs/contributors + misc tweaks #541
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not a fan of the "Possible future work" section, feature requests should go in issues, not in the README.
Also, things as vague as "Improve documentation" or "Performance optimizations" are useless, they are possible future work of any project out there.
e6e5b15
to
24c71ff
Compare
Though just the README, test-master will fail until #543 + nextcloud/password_policy#566 are merged. |
Signed-off-by: Josh <[email protected]>
24c71ff
to
bab0afc
Compare
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Closes #503
Builds on latest README changes from #539. Attempts to add notes useful to those looking to make changes to the Updater or understand its internals and how it fits in with the other pieces.
Also:
Lastly: