Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(files_trashbin): Allow preventing trash to be deleted permanently #50077

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat(files_trashbin): Allow preventing trash to be deleted permanently #50077

wants to merge 3 commits into from
+94 −10

Conversation

provokateurin
Copy link
Member

Summary

Checklist

@provokateurin provokateurin added this to the Nextcloud 31 milestone Jan 7, 2025
@provokateurin provokateurin force-pushed the feat/files_trashbin/allow-preventing-trash-permanently branch from ddd844a to ff1b072 Compare January 8, 2025 06:48
@provokateurin provokateurin added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 8, 2025
@provokateurin provokateurin marked this pull request as ready for review January 8, 2025 06:48
@provokateurin provokateurin requested review from a team, ArtificialOwl and artonge and removed request for a team January 8, 2025 06:49
@skjnldsv
Copy link
Member

skjnldsv commented Jan 8, 2025

Few minor comments, otherwise looks good! 👍
But please address them nonetheless

@provokateurin provokateurin force-pushed the feat/files_trashbin/allow-preventing-trash-permanently branch from ff1b072 to 5858070 Compare January 8, 2025 09:33
@blizzz blizzz mentioned this pull request Jan 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@sorbaugh sorbaugh sorbaugh approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@artonge artonge Awaiting requested review from artonge artonge was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement feature: files feature: trashbin
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
3 participants
@provokateurin @skjnldsv @sorbaugh