feat(files_sharing): add send mail toggle #50064
Open
+17
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
force-pushed
the
fix/49954/add-send-mail-toggle
branch
from
f178f55 to
4372d7a
Compare
5 tasks
|
Why not put it to true straight away? |
This sounds okay, but should not require another review cycle? cc: @skjnldsv |
For new internal shares, show the user a toggle for them configure if they want to send the share receiver a notification mail. This is subject to wether the configured user has an email send up Signed-off-by: nfebe <[email protected]>
nfebe
force-pushed
the
fix/49954/add-send-mail-toggle
branch
from
4372d7a to
c43bbd2
Compare
nfebe
commented
Jan 7, 2025
| @@ -329,8 +335,8 @@ export default { | |||
| data() { | |||
| return { | |||
| writeNoteToRecipientIsChecked: false, | |||
| sendNotificationMailOnCreation: true, | |||
There was a problem hiding this comment.
Suggested change
| sendNotificationMailOnCreation: true, | |
| sendNotificationMailOnCreation: true, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For new internal shares, show the user a toggle for them configure if they want to send the share receiver a notification mail.
This is subject to whether the configured user has an email send up
Screenshots
TODO