Skip to content

Commit

Permalink
fix(user_ldap): Use %n in plural translation to avoid a crash in L10N
Browse files Browse the repository at this point in the history
Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
come-nc committed Sep 15, 2024
1 parent 6d6baec commit 317c4ba
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions apps/user_ldap/lib/SetupChecks/LdapConnection.php
Original file line number Diff line number Diff line change
Expand Up @@ -58,23 +58,23 @@ public function run(): SetupResult {
if (!empty($bindFailedConfigurations)) {
$output .= $this->l10n->n(
'Binding failed for this LDAP configuration: %s',
'Binding failed for these LDAP configurations: %s',
'Binding failed for %n LDAP configurations: %s',
count($bindFailedConfigurations),
[implode(',', $bindFailedConfigurations)]
)."\n";
}
if (!empty($searchFailedConfigurations)) {
$output .= $this->l10n->n(
'Searching failed for this LDAP configuration: %s',
'Searching failed for these LDAP configurations: %s',
'Searching failed for %n LDAP configurations: %s',
count($searchFailedConfigurations),
[implode(',', $searchFailedConfigurations)]
)."\n";
}
if (!empty($inactiveConfigurations)) {
$output .= $this->l10n->n(
'There is an inactive LDAP configuration: %s',
'There are inactive LDAP configurations: %s',
'There are %n inactive LDAP configurations: %s',
count($inactiveConfigurations),
[implode(',', $inactiveConfigurations)]
)."\n";
Expand All @@ -86,7 +86,7 @@ public function run(): SetupResult {
}
return SetupResult::success($this->l10n->n(
'Binding and searching works on the configured LDAP connection (%s)',
'Binding and searching works on all of the configured LDAP connections (%s)',
'Binding and searching works on all of the %n configured LDAP connections (%s)',
count($availableConfigs),
[implode(',', $availableConfigs)]
));
Expand Down

0 comments on commit 317c4ba

Please sign in to comment.