Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mail snippets #10276

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: mail snippets #10276

wants to merge 10 commits into from

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Oct 17, 2024 •
edited
Loading

ref #10113
Testing:

  • Snippets CRUD operations are in Account settings
  • Inserting a snippet inside the composer is done with the '!' trigger

@hamza221 hamza221 linked an issue Oct 21, 2024 that may be closed by this pull request
Add a snippets to mail #10113
Open
4 tasks
@hamza221 hamza221 force-pushed the feat/snippets branch 2 times, most recently from f2dd62e to 11fc522 Compare October 31, 2024 18:00
@hamza221
Copy link
Contributor Author

Feature finally functioning the only thing missing is sharing fe and ui needs polishing

@hamza221
Copy link
Contributor Author

hamza221 commented Nov 6, 2024 •
edited
Loading

  • Html/preview support
  • fix share +UI

@hamza221 hamza221 marked this pull request as ready for review November 8, 2024 13:42
@hamza221 hamza221 self-assigned this Nov 8, 2024
@hamza221
feat: mail snippets
0857f9f 
Signed-off-by: Hamza Mahjoubi <[email protected]>
@hamza221
fixup! feat: mail snippets
396428e 
Signed-off-by: Hamza Mahjoubi <[email protected]>
@hamza221
fixup! feat: mail snippets
722b0b1 
Signed-off-by: Hamza Mahjoubi <[email protected]>
@hamza221
fixup! feat: mail snippets
51a37cf 
Signed-off-by: Hamza Mahjoubi <[email protected]>
@hamza221
fixup! feat: mail snippets
8390ed3 
Signed-off-by: Hamza Mahjoubi <[email protected]>
@hamza221
fixup! feat: mail snippets
04bf9c2 
Signed-off-by: Hamza Mahjoubi <[email protected]>
@hamza221
fixup! feat: mail snippets
e8f873e 
Signed-off-by: Hamza Mahjoubi <[email protected]>
@hamza221
fixup! feat: mail snippets
991c761 
Signed-off-by: Hamza Mahjoubi <[email protected]>
@hamza221
fixup! feat: mail snippets
fadacf6 
Signed-off-by: Hamza Mahjoubi <[email protected]>
@hamza221
fixup! feat: mail snippets
ff4cd0f 
Signed-off-by: Hamza Mahjoubi <[email protected]>
ChristophWurst
ChristophWurst reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests for the php part at least

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst left review comments

@kesselb kesselb Awaiting requested review from kesselb kesselb is a code owner

@GretaD GretaD Awaiting requested review from GretaD GretaD is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@hamza221 hamza221

Labels
3. to review enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a snippets to mail
2 participants
@hamza221 @ChristophWurst