Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(entity): Entity guid validation #1138

Merged
merged 3 commits into from
May 14, 2024
Merged

fix(entity): Entity guid validation #1138

merged 3 commits into from
May 14, 2024

Conversation

NSSPKrishna
Copy link
Member

This change will ensure that the customer-provided GUID is valid before it is accepted by the CLI, preventing any potential issues or errors that may arise from invalid input

@NSSPKrishna NSSPKrishna force-pushed the fix/guid-validation branch from d715ded to c08c81a Compare May 10, 2024 15:06
@NSSPKrishna NSSPKrishna requested a review from Nandu-pns May 10, 2024 15:07
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty clean!!

Copy link
Contributor

@Avinash-Sanpala Avinash-Sanpala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NSSPKrishna NSSPKrishna merged commit 235adb1 into main May 14, 2024
10 of 11 checks passed
@NSSPKrishna NSSPKrishna deleted the fix/guid-validation branch May 14, 2024 11:50
@GCamilleri
Copy link

GCamilleri commented May 15, 2024

@Avinash-Sanpala it looks like this may have caused a bug in the change tracking cli command: newrelic/newrelic-cli#1606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants