Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): fix tests by replacing obsolete entities and GUIDs #1091

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

pranav-new-relic
Copy link
Member

@pranav-new-relic pranav-new-relic commented Feb 7, 2024

Fixes to a few integration tests which are currently failing to run because GUIDs of entites they use no longer exist.
More details on changes made may be found in the comments added against each test-case change.

New Relic Internal: details of the instrumented app, its source, etc. can be found here.

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d6219dd) 37.64% compared to head (50a0fa4) 68.11%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1091       +/-   ##
===========================================
+ Coverage   37.64%   68.11%   +30.47%     
===========================================
  Files          85      103       +18     
  Lines        5409     6160      +751     
===========================================
+ Hits         2036     4196     +2160     
+ Misses       3221     1635     -1586     
- Partials      152      329      +177     
Flag Coverage Δ
integration 59.80% <ø> (?)
unit 37.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pranav-new-relic pranav-new-relic force-pushed the integration-tests-minor-fixes branch from 2c28e71 to ea99a1e Compare February 7, 2024 14:59
@pranav-new-relic pranav-new-relic marked this pull request as ready for review February 8, 2024 04:05
@pranav-new-relic pranav-new-relic merged commit ba1b165 into main Feb 8, 2024
10 checks passed
@pranav-new-relic pranav-new-relic deleted the integration-tests-minor-fixes branch February 8, 2024 04:05
@pranav-new-relic
Copy link
Member Author

Tests passing on other PRs too 👍 (pasting this for future reference)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants