-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tests): fix tests by replacing obsolete entities and GUIDs #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1091 +/- ##
===========================================
+ Coverage 37.64% 68.11% +30.47%
===========================================
Files 85 103 +18
Lines 5409 6160 +751
===========================================
+ Hits 2036 4196 +2160
+ Misses 3221 1635 -1586
- Partials 152 329 +177
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pranav-new-relic
commented
Feb 7, 2024
pranav-new-relic
commented
Feb 7, 2024
pranav-new-relic
force-pushed
the
integration-tests-minor-fixes
branch
from
February 7, 2024 14:59
2c28e71
to
ea99a1e
Compare
pranav-new-relic
commented
Feb 7, 2024
pranav-new-relic
commented
Feb 7, 2024
sanderblue
reviewed
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to a few integration tests which are currently failing to run because GUIDs of entites they use no longer exist.
More details on changes made may be found in the comments added against each test-case change.
New Relic Internal: details of the instrumented app, its source, etc. can be found here.