Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BrowserApplicationEntity): addition of browserProperties fields #1035

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

pranav-new-relic
Copy link
Member

@pranav-new-relic pranav-new-relic commented Jul 13, 2023

newrelic-client-go changes required by newrelic/terraform-provider-newrelic#2421.

Kindly head over to the PR linked above for more context on the necessity of these changes :) a detailed description has been attached.

However, a TL;DR version of this is below - the changes add the following fields to the getEntity and getEntities queries.

When a BrowserApplicationEntity is queried, the response comprises jsConfig inside browserProperties, that contains the following information (sensitive details redacted)

Request

{
  actor {
    entity(guid: "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX") {
      ... on BrowserApplicationEntity {
        guid
        name
        browserProperties {
          jsConfig
          jsConfigScript
          jsLoaderScript
        }
      }
    }
  }
}

@pranav-new-relic pranav-new-relic force-pushed the fix/add-browser-properties-fields branch from 30b99ff to d22f484 Compare July 13, 2023 06:33
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Merging #1035 (89a8a59) into main (a8b0fd1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1035   +/-   ##
=======================================
  Coverage   41.30%   41.30%           
=======================================
  Files          79       79           
  Lines        4995     4995           
=======================================
  Hits         2063     2063           
  Misses       2784     2784           
  Partials      148      148           
Flag Coverage Δ
unit 41.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/entities/entities_api.go 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pranav-new-relic pranav-new-relic force-pushed the fix/add-browser-properties-fields branch from aeec4a4 to bbae780 Compare October 11, 2023 09:43
@pranav-new-relic pranav-new-relic marked this pull request as ready for review October 11, 2023 10:03
mbazhlekova
mbazhlekova previously approved these changes Oct 11, 2023
@pranav-new-relic pranav-new-relic merged commit a215dd3 into main Oct 12, 2023
@pranav-new-relic pranav-new-relic deleted the fix/add-browser-properties-fields branch October 12, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants