fix: integration tests (#1064)

newrelic · Nov 9, 2023 · f452d6f · f452d6f
1 parent 9883c83
commit f452d6f
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 31 deletions.
diff --git a/pkg/alerts/conditions_integration_test.go b/pkg/alerts/conditions_integration_test.go
@@ -13,7 +13,7 @@ import (
 )
 
 func TestIntegrationConditions(t *testing.T) {
-	t.Parallel()
+	t.Skipf("This a legacy API which will be deprecated soon")
 
 	var (
 		testConditionRandStr = nr.RandSeq(5)

diff --git a/pkg/apm/labels_integration_test.go b/pkg/apm/labels_integration_test.go
@@ -13,7 +13,7 @@ import (
 )
 
 func TestIntegrationLabels(t *testing.T) {
-	t.Parallel()
+	t.Skipf("This API is deprecated so it always returns an error")
 
 	client := newIntegrationTestClient(t)
 

diff --git a/pkg/synthetics/monitor_locations_integration_test.go b/pkg/synthetics/monitor_locations_integration_test.go
@@ -12,7 +12,7 @@ import (
 )
 
 func TestIntegrationGetMonitorLocations(t *testing.T) {
-	t.Parallel()
+	t.Skipf("Synthetics REST API is deprecated")
 
 	tc := mock.NewIntegrationTestConfig(t)
 

diff --git a/pkg/synthetics/monitors_integration_test.go b/pkg/synthetics/monitors_integration_test.go
@@ -27,7 +27,7 @@ var (
 )
 
 func TestIntegrationMonitors(t *testing.T) {
-	t.Parallel()
+	t.Skipf("Synthetics REST API is deprecated")
 
 	tc := mock.NewIntegrationTestConfig(t)
 

diff --git a/pkg/synthetics/secure_credentials_integration_test.go b/pkg/synthetics/secure_credentials_integration_test.go
@@ -24,7 +24,7 @@ var (
 )
 
 func TestIntegrationSecureCredentials(t *testing.T) {
-	t.Parallel()
+	t.Skipf("Synthetics REST API is deprecated")
 
 	tc := mock.NewIntegrationTestConfig(t)
 	synthetics := New(tc)

diff --git a/pkg/synthetics/synthetics_api_integration_test.go b/pkg/synthetics/synthetics_api_integration_test.go
@@ -19,8 +19,6 @@ import (
 var tv bool = true
 
 func TestSyntheticsSecureCredential_Basic(t *testing.T) {
-	t.Parallel()
-
 	testAccountID, err := mock.GetTestAccountID()
 	if err != nil {
 		t.Skipf("%s", err)
@@ -41,8 +39,6 @@ func TestSyntheticsSecureCredential_Basic(t *testing.T) {
 }
 
 func TestSyntheticsSecureCredential_Error(t *testing.T) {
-	t.Parallel()
-
 	testAccountID, err := mock.GetTestAccountID()
 	if err != nil {
 		t.Skipf("%s", err)
@@ -56,7 +52,6 @@ func TestSyntheticsSecureCredential_Error(t *testing.T) {
 }
 
 func TestSyntheticsSimpleBrowserMonitor_Basic(t *testing.T) {
-	t.Parallel()
 
 	testAccountID, err := mock.GetTestAccountID()
 	if err != nil {
@@ -164,7 +159,6 @@ func TestSyntheticsSimpleBrowserMonitor_Basic(t *testing.T) {
 }
 
 func TestSyntheticsSimpleMonitor_Basic(t *testing.T) {
-	t.Parallel()
 	testAccountID, err := mock.GetTestAccountID()
 	if err != nil {
 		t.Skipf("%s", err)
@@ -255,7 +249,6 @@ func TestSyntheticsSimpleMonitor_Basic(t *testing.T) {
 }
 
 func TestSyntheticsScriptApiMonitor_Basic(t *testing.T) {
-	t.Parallel()
 
 	testAccountID, err := mock.GetTestAccountID()
 	if err != nil {
@@ -361,7 +354,6 @@ func TestSyntheticsScriptApiMonitor_Basic(t *testing.T) {
 }
 
 func TestSyntheticsScriptApiMonitorLegacy_Basic(t *testing.T) {
-	t.Parallel()
 
 	testAccountID, err := mock.GetTestAccountID()
 	if err != nil {
@@ -457,7 +449,6 @@ func TestSyntheticsScriptApiMonitorLegacy_Basic(t *testing.T) {
 }
 
 func TestSyntheticsScriptBrowserMonitor_Basic(t *testing.T) {
-	t.Parallel()
 	testAccountID, err := mock.GetTestAccountID()
 	if err != nil {
 		t.Skipf("%s", err)
@@ -539,7 +530,6 @@ func TestSyntheticsScriptBrowserMonitor_Basic(t *testing.T) {
 }
 
 func TestSyntheticsScriptBrowserMonitor_InvalidRuntimeValues(t *testing.T) {
-	t.Parallel()
 	testAccountID, err := mock.GetTestAccountID()
 	if err != nil {
 		t.Skipf("%s", err)
@@ -570,7 +560,6 @@ func TestSyntheticsScriptBrowserMonitor_InvalidRuntimeValues(t *testing.T) {
 }
 
 func TestSyntheticsScriptBrowserMonitor_DeviceEmulation(t *testing.T) {
-	t.Parallel()
 	testAccountID, err := mock.GetTestAccountID()
 	if err != nil {
 		t.Skipf("%s", err)
@@ -641,7 +630,6 @@ func TestSyntheticsScriptBrowserMonitor_DeviceEmulation(t *testing.T) {
 }
 
 func TestSyntheticsScriptBrowserMonitor_LegacyRuntime(t *testing.T) {
-	t.Parallel()
 	testAccountID, err := mock.GetTestAccountID()
 	if err != nil {
 		t.Skipf("%s", err)
@@ -702,7 +690,6 @@ func TestSyntheticsScriptBrowserMonitor_LegacyRuntime(t *testing.T) {
 }
 
 func TestSyntheticsPrivateLocation_Basic(t *testing.T) {
-	t.Parallel()
 
 	testAccountID, err := mock.GetTestAccountID()
 	if err != nil {
@@ -727,7 +714,6 @@ func TestSyntheticsPrivateLocation_Basic(t *testing.T) {
 }
 
 func TestSyntheticsBrokenLinksMonitor_Basic(t *testing.T) {
-	t.Parallel()
 	testAccountID, err := mock.GetTestAccountID()
 	if err != nil {
 		t.Skipf("%s", err)
@@ -782,7 +768,6 @@ func TestSyntheticsBrokenLinksMonitor_Basic(t *testing.T) {
 }
 
 func TestSyntheticsCertCheckMonitor_Basic(t *testing.T) {
-	t.Parallel()
 	testAccountID, err := mock.GetTestAccountID()
 	if err != nil {
 		t.Skipf("%s", err)
@@ -840,7 +825,6 @@ func TestSyntheticsCertCheckMonitor_Basic(t *testing.T) {
 }
 
 func TestSyntheticsStepMonitor_Basic(t *testing.T) {
-	t.Parallel()
 	testAccountID, err := mock.GetTestAccountID()
 	if err != nil {
 		t.Skipf("%s", err)
@@ -922,7 +906,6 @@ func TestSyntheticsStepMonitor_Basic(t *testing.T) {
 }
 
 func TestSyntheticsStepMonitor_GetSteps(t *testing.T) {
-	t.Parallel()
 	testAccountID, err := mock.GetTestAccountID()
 	if err != nil {
 		t.Skipf("%s", err)
@@ -979,7 +962,6 @@ func TestSyntheticsStepMonitor_GetSteps(t *testing.T) {
 }
 
 func TestSyntheticsStepMonitor_GetScript(t *testing.T) {
-	t.Parallel()
 	testAccountID, err := mock.GetTestAccountID()
 	if err != nil {
 		t.Skipf("%s", err)
@@ -1029,7 +1011,6 @@ func newIntegrationTestClient(t *testing.T) Synthetics {
 // syntheticsStartAutomatedTest mutation to create a batch with these three monitors. The expected
 // behaviour of this test is to return a valid batchId and throw no error.
 func TestSyntheticsStartAutomatedTest_Basic(t *testing.T) {
-	t.Parallel()
 	t.Skipf(
 		`Temporarily skipping tests associated with the Synthetics Automated Tests feature, ` +
 			`given the API is currently unstable and endpoint access is not configured to all accounts at the moment.
@@ -1176,7 +1157,6 @@ func TestSyntheticsStartAutomatedTest_Basic(t *testing.T) {
 // TestSyntheticsStartAutomatedTest_Error performs a test on the syntheticsStartAutomatedTest mutation by specifying
 // an invalid GUID in the input field of a monitor to obtain an error, in alignment with expected behaviour.
 func TestSyntheticsStartAutomatedTest_Error(t *testing.T) {
-	t.Parallel()
 	t.Skipf(
 		`Temporarily skipping tests associated with the Synthetics Automated Tests feature, ` +
 			`given the API is currently unstable and endpoint access is not configured to all accounts at the moment.
@@ -1198,7 +1178,6 @@ func TestSyntheticsStartAutomatedTest_Error(t *testing.T) {
 // TestSyntheticsAutomatedTestResults_TwoMonitorsTest performs a test by creating two scripted browser monitors,
 // creating a batch with those monitors, querying the batch and evaluating the status accordingly.
 func TestSyntheticsAutomatedTestResults_TwoMonitorsTest(t *testing.T) {
-	t.Parallel()
 	t.Skipf(
 		`Temporarily skipping tests associated with the Synthetics Automated Tests feature, ` +
 			`given the API is currently unstable and endpoint access is not configured to all accounts at the moment.
@@ -1285,7 +1264,6 @@ func TestSyntheticsAutomatedTestResults_TwoMonitorsTest(t *testing.T) {
 // creating a batch with the monitor, querying the batch and evaluating the status accordingly. Since the scripted
 // browser monitor is bound to fail, this tests inspects the consolidated status and the status of the monitor.
 func TestSyntheticsAutomatedTestResults_OneMonitorTest(t *testing.T) {
-	t.Parallel()
 	t.Skipf(
 		`Temporarily skipping tests associated with the Synthetics Automated Tests feature, ` +
 			`given the API is currently unstable and endpoint access is not configured to all accounts at the moment.
@@ -1351,7 +1329,6 @@ func TestSyntheticsAutomatedTestResults_OneMonitorTest(t *testing.T) {
 // TestSyntheticsAutomatedTestResults_ErrorTest performs a test on the automatedTestResults query by
 // specifying an invalid batchId, which is expected to throw an error.
 func TestSyntheticsAutomatedTestResults_ErrorTest(t *testing.T) {
-	t.Parallel()
 	t.Skipf(
 		`Temporarily skipping tests associated with the Synthetics Automated Tests feature, ` +
 			`given the API is currently unstable and endpoint access is not configured to all accounts at the moment.

diff --git a/pkg/workflows/workflows_integration_test.go b/pkg/workflows/workflows_integration_test.go
@@ -86,7 +86,7 @@ func TestIntegrationCreateWorkflowWithoutNotificationTriggers(t *testing.T) {
 	defer cleanupWorkflow(t, &createResult.Workflow)
 	var createdWorkflow = createResult.Workflow
 
-	require.Equal(t, []AiWorkflowsNotificationTrigger(nil), createdWorkflow.DestinationConfigurations[0].NotificationTriggers)
+	require.Equal(t, []AiWorkflowsNotificationTrigger{"ACKNOWLEDGED", "ACTIVATED", "CLOSED", "PRIORITY_CHANGED"}, createdWorkflow.DestinationConfigurations[0].NotificationTriggers)
 }
 
 func TestIntegrationDeleteWorkflow_CanDeleteChannels(t *testing.T) {
@@ -235,7 +235,7 @@ func TestIntegrationUpdateWorkflow_UpdateEverything(t *testing.T) {
 				Name: "filter-test-update",
 				Type: AiWorkflowsFilterTypeTypes.FILTER,
 				Predicates: []AiWorkflowsPredicateInput{{
-					Attribute: "source",
+					Attribute: "accumulations.sources",
 					Operator:  AiWorkflowsOperatorTypes.CONTAINS,
 					Values:    []string{"servicenow"},
 				}},
@@ -453,7 +453,7 @@ func generateCreateWorkflowInput(channel *notifications.AiNotificationsChannel,
 		Name: "filter-test",
 		Type: AiWorkflowsFilterTypeTypes.FILTER,
 		Predicates: []AiWorkflowsPredicateInput{{
-			Attribute: "source",
+			Attribute: "accumulations.sources",
 			Operator:  AiWorkflowsOperatorTypes.CONTAINS,
 			Values:    []string{"newrelic"},
 		}},