Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(entities): Support custom attributes JSON (2) #1531

Merged
merged 14 commits into from
Nov 8, 2023

Conversation

amolero-nr
Copy link
Contributor

@amolero-nr amolero-nr commented Nov 2, 2023

Supports JSON strings for --customAttributes in the newrelic entity deployment create command for deployment markers. Ref: NR-165686.

*** Requires *** newrelic/newrelic-client-go#1063 in a newrelic-client-go release > 2.22.0

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #1531 (5c9764c) into main (e1bf884) will increase coverage by 0.14%.
The diff coverage is 59.45%.

@@            Coverage Diff             @@
##             main    #1531      +/-   ##
==========================================
+ Coverage   47.34%   47.49%   +0.14%     
==========================================
  Files         125      125              
  Lines        7724     7751      +27     
==========================================
+ Hits         3657     3681      +24     
- Misses       3926     3930       +4     
+ Partials      141      140       -1     
Files Coverage Δ
internal/entities/command_deployment.go 57.14% <59.45%> (+5.58%) ⬆️

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@amolero-nr amolero-nr force-pushed the feat/custom-attributes branch from 2e76c04 to cfb3960 Compare November 7, 2023 21:51
@sanderblue sanderblue force-pushed the feat/custom-attributes branch from c25adb8 to 34b8024 Compare November 7, 2023 22:17
@sanderblue sanderblue force-pushed the feat/custom-attributes branch from 34b8024 to 5c9764c Compare November 7, 2023 22:18
@amolero-nr amolero-nr merged commit dbae5e0 into main Nov 8, 2023
25 of 26 checks passed
@amolero-nr amolero-nr deleted the feat/custom-attributes branch November 8, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants