-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(entities): Support custom attributes JSON (2) #1531
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1531 +/- ##
==========================================
+ Coverage 47.34% 47.49% +0.14%
==========================================
Files 125 125
Lines 7724 7751 +27
==========================================
+ Hits 3657 3681 +24
- Misses 3926 3930 +4
+ Partials 141 140 -1
... and 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
sanderblue
suggested changes
Nov 7, 2023
sanderblue
reviewed
Nov 7, 2023
amolero-nr
force-pushed
the
feat/custom-attributes
branch
from
November 7, 2023 21:51
2e76c04
to
cfb3960
Compare
sanderblue
force-pushed
the
feat/custom-attributes
branch
from
November 7, 2023 22:17
c25adb8
to
34b8024
Compare
sanderblue
force-pushed
the
feat/custom-attributes
branch
from
November 7, 2023 22:18
34b8024
to
5c9764c
Compare
sanderblue
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports JSON strings for
--customAttributes
in thenewrelic entity deployment create
command for deployment markers. Ref: NR-165686.*** Requires *** newrelic/newrelic-client-go#1063 in a
newrelic-client-go
release > 2.22.0