-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: NR 328461 add CLS browser golden signals #1839
base: main
Are you sure you want to change the base?
feat: NR 328461 add CLS browser golden signals #1839
Conversation
…and summary metrics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beep boop bop.
I have found some errors processing these changes:
* Error PARSING domainType: 'browser-application' on LinkedHashMap<String, entitydefinitionemitter.models.CustomSummaryMetricDefinition> - jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `entitydefinitionsclientmetrics.models.definitions.MetricUnit` from String "NUMBER": not one of the values accepted for Enum class: [MS, APDEX, MESSAGES_PER_SECOND, BYTES_PER_SECOND, BYTES, BITS_PER_SECOND, PAGES_PER_SECOND, TIMESTAMP, PERCENTAGE, HERTZ, CELSIUS, SECONDS, BITS, OPERATIONS_PER_SECOND, COUNT, REQUESTS_PER_SECOND, REQUESTS_PER_MINUTE, STRING]
at [Source: (StringReader); line: 15, column: 9] (through reference chain: LinkedHashMap["cumulativeLayoutShift75Percentile"]->entitydefinitionemitter.models.CustomSummaryMetricDefinition["unit"])
* Error PARSING domainType: 'browser-application' on LinkedHashMap<String, entitydefinitionemitter.models.CustomGoldenMetricDefinition> - jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `entitydefinitionsclientmetrics.models.definitions.MetricUnit` from String "NUMBER": not one of the values accepted for Enum class: [MS, APDEX, MESSAGES_PER_SECOND, BYTES_PER_SECOND, BYTES, BITS_PER_SECOND, PAGES_PER_SECOND, TIMESTAMP, PERCENTAGE, HERTZ, CELSIUS, SECONDS, BITS, OPERATIONS_PER_SECOND, COUNT, REQUESTS_PER_SECOND, REQUESTS_PER_MINUTE, STRING]
at [Source: (StringReader); line: 27, column: 9] (through reference chain: LinkedHashMap["cumulativeLayoutShift75Percentile"]->entitydefinitionemitter.models.CustomGoldenMetricDefinition["unit"])
…ric in golden and summary metrics
We cannot arbitrarily add units on our side. Those need to be changed/allowed on the upstream systems before we can change our validations. Added more context here: link |
@@ -22,6 +22,14 @@ interactionToNextPaint75PercentileS: | |||
from: PageViewTiming | |||
eventId: entityGuid | |||
eventName: appName | |||
cumulativeLayoutShift75Percentile: | |||
title: Cumulative layout shift (75 percentile) | |||
unit: STRING |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think STRING is the proper unit here.
Is there any specific reason why this should be an STRING?
I totally understand that any other values in the ENUM do not fit completely your needs, but I'd not put an STRING here.
In many other places, we use just COUNT
, which is the default.
The COUNT
unit, is shown as no just a number in the UI.
Let me share some examples:
cpuUsage: |
throttles: |
…ric in golden and summary metrics
Relevant information
The Browser is extending the support of CLS (Cumulative Layout Shift ) a core web vital which is missing as the other two are already added.
Ticket : https://new-relic.atlassian.net/browse/NR-328461
Checklist
identifier
will be unique and valid.