Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NR 328461 add CLS browser golden signals #1839

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

shivalagisetty
Copy link

Relevant information

The Browser is extending the support of CLS (Cumulative Layout Shift ) a core web vital which is missing as the other two are already added.

Ticket : https://new-relic.atlassian.net/browse/NR-328461

Checklist

  • I've read the guidelines and understand the acceptance criteria.
  • The value of the attribute marked as identifier will be unique and valid.
  • I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.

Copy link

@entityBot entityBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep boop bop.

I have found some errors processing these changes:

* Error PARSING domainType: 'browser-application' on LinkedHashMap<String, entitydefinitionemitter.models.CustomSummaryMetricDefinition> - jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `entitydefinitionsclientmetrics.models.definitions.MetricUnit` from String "NUMBER": not one of the values accepted for Enum class: [MS, APDEX, MESSAGES_PER_SECOND, BYTES_PER_SECOND, BYTES, BITS_PER_SECOND, PAGES_PER_SECOND, TIMESTAMP, PERCENTAGE, HERTZ, CELSIUS, SECONDS, BITS, OPERATIONS_PER_SECOND, COUNT, REQUESTS_PER_SECOND, REQUESTS_PER_MINUTE, STRING]
at [Source: (StringReader); line: 15, column: 9] (through reference chain: LinkedHashMap["cumulativeLayoutShift75Percentile"]->entitydefinitionemitter.models.CustomSummaryMetricDefinition["unit"])

* Error PARSING domainType: 'browser-application' on LinkedHashMap<String, entitydefinitionemitter.models.CustomGoldenMetricDefinition> - jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `entitydefinitionsclientmetrics.models.definitions.MetricUnit` from String "NUMBER": not one of the values accepted for Enum class: [MS, APDEX, MESSAGES_PER_SECOND, BYTES_PER_SECOND, BYTES, BITS_PER_SECOND, PAGES_PER_SECOND, TIMESTAMP, PERCENTAGE, HERTZ, CELSIUS, SECONDS, BITS, OPERATIONS_PER_SECOND, COUNT, REQUESTS_PER_SECOND, REQUESTS_PER_MINUTE, STRING]
at [Source: (StringReader); line: 27, column: 9] (through reference chain: LinkedHashMap["cumulativeLayoutShift75Percentile"]->entitydefinitionemitter.models.CustomGoldenMetricDefinition["unit"])

@CLAassistant
Copy link

CLAassistant commented Jan 6, 2025

CLA assistant check
All committers have signed the CLA.

@shivalagisetty shivalagisetty marked this pull request as ready for review January 6, 2025 20:34
@shivalagisetty shivalagisetty changed the title Nr 328461 add cls browser golden signals feat: NR 328461 add CLS browser golden signals Jan 6, 2025
github-actions[bot]
github-actions bot previously approved these changes Jan 7, 2025
@otaviocarvalho
Copy link
Contributor

We cannot arbitrarily add units on our side. Those need to be changed/allowed on the upstream systems before we can change our validations.

Added more context here: link

@@ -22,6 +22,14 @@ interactionToNextPaint75PercentileS:
from: PageViewTiming
eventId: entityGuid
eventName: appName
cumulativeLayoutShift75Percentile:
title: Cumulative layout shift (75 percentile)
unit: STRING
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think STRING is the proper unit here.

Is there any specific reason why this should be an STRING?

I totally understand that any other values in the ENUM do not fit completely your needs, but I'd not put an STRING here.

In many other places, we use just COUNT, which is the default.
The COUNT unit, is shown as no just a number in the UI.

Let me share some examples:

github-actions[bot]
github-actions bot previously approved these changes Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants