Daily release/10/24/2023/afternoon #14970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated translations - (machine translation)
Updated translations - 2023-10-24
The doc went back and forth from `groupId` to `groupID`. I'm not positive if `groupID` is a problem, but I made it consistent with the way I know works.
Confirmed our prometheus agent default scrape value is 30s not 15s. The global default within prometheus documentation is 1m. Updated the recommendations sections to reflect the correct values. Per prometheus documentation, the global scrape_interval is set to 1 minute by default. https://prometheus.io/docs/prometheus/latest/configuration/configuration/#configuration-file Our prometheus agent is set to 30 seconds by default. I double checked with Engineering. https://github.com/newrelic/newrelic-prometheus-configurator/blob/7dcb9392349cef3d2a44aad5a0371e9719ea12ef/charts/newrelic-prometheus-agent/values.yaml#L134 https://newrelic.slack.com/archives/C04S2FT1LU9/p1698164053929219?thread_ts=1698162082.068379&cid=C04S2FT1LU9
fix: groupID to groupId
Update send-prometheus-metric-data-new-relic.mdx
docs: Add in release notes for iOS mobile app 5.7.1
chore: move default template
Browser Agent v1.246.0 Release Notes
rhetoric101
requested review from
a team,
clarkmcadoo and
tabathadelane
and removed request for
a team
|
Hi @rhetoric101 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes). |
✅ docs-website deploy preview ready
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.