Change Cognito JWT authorizer to use the right Client ID #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casewalker
requested review from
dhcole,
mluedke2,
jasnoo,
aloverso,
namanaman,
noah-marcus,
ashlsun and
sannidhishukla
namanaman
approved these changes
Nov 6, 2023
| @@ -24,7 +25,7 @@ provider: | |||
| type: jwt | |||
| identitySource: $request.header.Authorization | |||
| issuerUrl: "https://cognito-idp.us-east-1.amazonaws.com/${self:provider.environment.COGNITO_USER_POOL}" | |||
| audience: [ 4bfgopjuh6lmgg4t66qf9uphrb ] | |||
| audience: [ "${self:provider.environment.COGNITO_APP_CLIENT_ID}" ] | |||
There was a problem hiding this comment.
question to make sure i understand - the old audience was an older user pool and the new value above is for the new user pool that's actually in use?
There was a problem hiding this comment.
Exactly, within a User Pool you can create an App Client, and this is the bridge between Cognito and the application that uses Cognito for authentication. When I deleted the old User Pool and created a new one to fix MFA issues, I then also had to create a new App Client in the new User Pool and I forgot to update that config here.
sannidhishukla
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the last commit, I forgot that I had hard-coded the Cognito User Pool's "App Integration - Client ID" lower in the serverless config. This commit pulls the value out into a constant and updates it to the new value for the new User Pool.