Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(model_card): Added model cards for current models #111

Merged
merged 12 commits into from
Jan 31, 2024
Merged

Conversation

gaiborjosue
Copy link
Contributor

@gaiborjosue gaiborjosue commented Nov 25, 2023

This PR will successfully add model_card.yaml files to all current models for it to be compatible with the updated workflow seen here: #106

Thus, if merged, it will successfully close #110

The purpose of having a "model_card.yaml" is to have a specific file for the model's information, not to have the information embedded into spec.yaml. One is used for technical processing, and the other one for information about each model. For more information on the model card please visit: https://github.com/neuronets/trained-models/tree/master/docs

@gaiborjosue gaiborjosue requested a review from hvgazula November 25, 2023 00:23
@gaiborjosue gaiborjosue self-assigned this Nov 25, 2023
@gaiborjosue gaiborjosue linked an issue Nov 25, 2023 that may be closed by this pull request
@gaiborjosue gaiborjosue requested a review from satra November 25, 2023 00:23
Copy link
Contributor

@hvgazula hvgazula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hvgazula hvgazula merged commit 33877bb into master Jan 31, 2024
@hvgazula hvgazula deleted the 110-add-cards branch January 31, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add model_card.yaml to current models
2 participants