feat: add keypad numbers to correct answer #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 8e0a318): https://borton-task-msit--pr53-keypad-answer-hemeb0wc.web.app (expires Thu, 05 Aug 2021 17:40:04 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
probably not going to merge this before all the baylor stuff is done. |
mcmcgrath13
reviewed
Jul 22, 2021
| @@ -116,17 +116,13 @@ export function rt_categorize_html() { | |||
|
|
|||
| // create response function | |||
| var after_response = function(info) { | |||
|
|
|||
| // kill any remaining setTimeout handlers | |||
| jsPsych.pluginAPI.clearAllTimeouts(); | |||
|
|
|||
| // clear keyboard listener | |||
| jsPsych.pluginAPI.cancelAllKeyboardResponses(); | |||
|
|
|||
There was a problem hiding this comment.
I'd also save the key_answer with the trial_data to be safe
suivo2001
commented
Jul 29, 2021
|
|
||
| // save data | ||
| trial_data = { | ||
| "rt": info.rt, | ||
| "correct": correct, | ||
| "stimulus": trial.stimulus, | ||
| "key_press": info.key | ||
| "key_press": info.key, | ||
| "key_answer": trial.key_answer |
There was a problem hiding this comment.
@mcmcgrath13 is this what you meant with the above comment?
mcmcgrath13
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data json changes a bit with this.
The
codefield, which was 1,2,3 corresponding to the correct answer is gone, and that number is inkey_answernow. Thekey_answerfrom before, which was 48,49,50 corresponding to the right number key is also gone.