Update OneShot Test Pathways #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 5, 2024 21:54
Satrat
requested review from
dbogunowicz,
bfineran,
dsikka,
rahul-tuli and
horheynm
dbogunowicz
previously approved these changes
Apr 8, 2024
dsikka
previously approved these changes
Apr 9, 2024
mgoin
reviewed
Apr 9, 2024
bfineran
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the oneshot tests were using the old pathway from before we merged finetuning and oneshot to a single script. Updating everything to use the latest pathways. A future PR will focus on refactoring tests into the new unit test framework
Asana ticket: https://app.asana.com/0/1201735099598270/1207004126198306/f