Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: diode helm chart #184

Merged
merged 32 commits into from
Oct 15, 2024
Merged

feat: diode helm chart #184

merged 32 commits into from
Oct 15, 2024

Conversation

mfiedorowicz
Copy link
Member

Initial version of the diode helm chart

@mfiedorowicz
feat: diode helm chart
a04c2f6 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz mfiedorowicz self-assigned this Oct 15, 2024
jit-ci[bot]
jit-ci bot reviewed Oct 15, 2024
View reviewed changes
Copy link

@jit-ci jit-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Jit has detected 1 important finding in this PR that you should review.
The finding is detailed below as a comment.
It’s highly recommended that you fix this security issue before merge.

charts/diode/values.yaml Show resolved Hide resolved
@mfiedorowicz
gha: add diode chart labeler
1d528ba 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
gha: add helm lint workflow
217a781 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
gha(helm-lint): build dependencies
d5ddcac 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
gha(helm-lint): fix job name and update deps step
691cf34 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
update diode chart readme
45e986b 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
gha: add helm release workflow
803a776 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
update diode chart readme
e1f46b9 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
update diode chart readme
259fdac 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
tidy up diode chart readme
c5eabd4 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
gha(helm-release): remove pr permission
10b0599 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
gha(helm-release): test release
4818668 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
pin diode service versions
6a68e78 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
test chart version bump
571cdaa 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
gha(helm-release): skip existing checks
8fac2b0 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
gha(helm-release): try charts_dir
6f805f3 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
gha(helm-release): try fetch-depth
7c659f2 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
gha(helm-release): build dependencies
918a30c 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
gha(helm-release): add dependency repos
290f557 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
gha(helm-release): test git config
5d8c362 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
gha(helm-release): use github-actions user
555a4f1 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
trigger test release
c9baac8 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
gha(helm-release): use GITHUB_ACTOR user
9bd8dee 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
gha(helm-release): customise release name template
3583da6 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
update readme
328eff5 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
gha(helm-release): customise index path
3e2d75a 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
gha(helm-release): customise index path
4745f01 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
gha(helm-release): remove pages index path
17e9c39 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
gha(helm-release): index path, another attempt
2dbc25c 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
test bump chart version
d07acf8 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
de-bump chart version
6928b6e 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
tidy up helm-release
0f67c58 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz mfiedorowicz marked this pull request as ready for review October 15, 2024 16:03
leoparente
leoparente approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@leoparente leoparente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But, would wait for the experts

RangerRick
RangerRick approved these changes Oct 15, 2024
View reviewed changes
Copy link

@RangerRick RangerRick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a lot to take in, so I'm not convinced I didn't miss something, but this looks pretty good. You're handling all the kind of stuff I would expect you to handle, and it seems pretty easy to manage customizing sub-charts and config.

@mfiedorowicz mfiedorowicz merged commit 216f3a6 into develop Oct 15, 2024
5 checks passed
@mfiedorowicz mfiedorowicz deleted the diode-chart branch October 15, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jit-ci jit-ci[bot] jit-ci[bot] left review comments

@leoparente leoparente leoparente approved these changes

@RangerRick RangerRick RangerRick approved these changes

@rcrawf rcrawf Awaiting requested review from rcrawf

Assignees

@mfiedorowicz mfiedorowicz

Labels
github-actions markdown
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfiedorowicz @RangerRick @leoparente