Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(proto): add entity_label field option #182

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

feat(proto): add entity_label field option #182

wants to merge 3 commits into from

Conversation

mfiedorowicz
Copy link
Member

Add entity_label field option to indicate which entity field should be used as label.

@mfiedorowicz
feat: add entity_label field option
06ff545 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
bump field number
5daf60f 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
bump field number
35f0be2 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz mfiedorowicz self-assigned this Oct 7, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation go markdown diode-proto diode-server labels Oct 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 1.24s github.com/netboxlabs/diode/diode-server/ingester 4.3% 9 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/netbox 0.0% 0 0 0
🟢 PASS 1.59s github.com/netboxlabs/diode/diode-server/netboxdiodeplugin 3.2% 40 0 0
🟢 PASS 1.46s github.com/netboxlabs/diode/diode-server/reconciler 12.4% 65 0 0
🟢 PASS 1.46s github.com/netboxlabs/diode/diode-server/reconciler/changeset 34.2% 81 0 0
🟢 PASS 1.02s github.com/netboxlabs/diode/diode-server/server 85.7% 14 0 0
🟢 PASS 1.01s github.com/netboxlabs/diode/diode-server/version 100.0% 1 0 0

Total coverage: 80.0%

leoparente
leoparente approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@leoparente leoparente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mastering Protobuf. LGTM!

@mfiedorowicz mfiedorowicz changed the title feat: add entity_label field option feat(proto): add entity_label field option Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoparente leoparente leoparente approved these changes

Assignees

@mfiedorowicz mfiedorowicz

Labels
diode-proto diode-server documentation Improvements or additions to documentation go markdown
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfiedorowicz @leoparente