Skip to content

Commit

Permalink
Merge pull request #36 from netboxlabs/develop
Browse files Browse the repository at this point in the history
release: servers trigger test
  • Loading branch information
mfiedorowicz authored Feb 15, 2024
2 parents 3a6f369 + db3e2dc commit 5683d10
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 3 deletions.
16 changes: 14 additions & 2 deletions .github/workflows/server-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ jobs:
get-next-version:
uses: netboxlabs/diode/.github/workflows/reusable_semantic_release_get_next_version.yaml@develop
needs: [ setup ]
strategy:
fail-fast: false
matrix: ${{ fromJson(needs.setup.outputs.matrix) }}
if: needs.setup.outputs.matrix != ''
with:
# passed vars need hard coding - https://docs.github.com/en/actions/using-workflows/reusing-workflows#limitations
app_name: ${{ matrix.server }}
Expand All @@ -47,8 +51,12 @@ jobs:

build:
name: Build ${{ matrix.server }}
needs: [ get-next-version ]
needs: [ get-next-version, setup ]
strategy:
fail-fast: false
matrix: ${{ fromJson(needs.setup.outputs.matrix) }}
runs-on: ubuntu-latest
if: needs.setup.outputs.matrix != ''
defaults:
run:
working-directory: diode-server/cmd/${{ matrix.server }}
Expand All @@ -71,7 +79,11 @@ jobs:

semantic-release:
uses: netboxlabs/diode/.github/workflows/reusable_semantic_release.yaml@develop
needs: [ build ]
needs: [ build, setup ]
strategy:
fail-fast: false
matrix: ${{ fromJson(needs.setup.outputs.matrix) }}
if: needs.setup.outputs.matrix != ''
with:
app_dir: diode-server/cmd/${{ matrix.server }}
secrets: inherit
Expand Down
2 changes: 1 addition & 1 deletion diode-server/server/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ func (s *Server) Logger() *slog.Logger {
return s.logger
}

// RegisterComponent registers a Component with the Server
// RegisterComponent registers a Component with the Server.
func (s *Server) RegisterComponent(c Component) error {
s.mu.Lock()
defer s.mu.Unlock()
Expand Down

0 comments on commit 5683d10

Please sign in to comment.