Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: init diode-go-sdk (part 2) #2

Merged
merged 26 commits into from
Aug 27, 2024
Merged

Conversation

mfiedorowicz
Copy link
Member

@mfiedorowicz mfiedorowicz commented Aug 21, 2024

  • parity with diode-sdk-python on loading API keys, system cert pool (root CAs), grpc method interceptor, etc.
  • code generator for client ingestion entity types (wrappers around proto generated ones)
  • unit tests
  • example usage code samples

Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Copy link

github-actions bot commented Aug 21, 2024

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 1.13s github.com/netboxlabs/diode-sdk-go/diode 96.3% 146 0 0

Total coverage: 96.3%

Copy link

@jit-ci jit-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ The following Jit checks failed to run:

  • software-component-analysis-go

#jit_bypass_commit in this PR to bypass, Jit Admin privileges required.

More info in the Jit platform.

Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
Signed-off-by: Michal Fiedorowicz <[email protected]>
@github-actions github-actions bot added documentation Improvements or additions to documentation markdown labels Aug 27, 2024
@mfiedorowicz mfiedorowicz marked this pull request as ready for review August 27, 2024 09:47
Signed-off-by: Michal Fiedorowicz <[email protected]>
Copy link

@leoparente leoparente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. LGTM.

@mfiedorowicz mfiedorowicz changed the title feat: diode-go-sdk improvements feat: init diode-go-sdk (part 2) Aug 27, 2024
@mfiedorowicz mfiedorowicz merged commit 64f0fde into develop Aug 27, 2024
7 checks passed
@mfiedorowicz mfiedorowicz deleted the feat/init-diode-sdk-go branch August 27, 2024 13:30
@orb-ci
Copy link

orb-ci commented Aug 27, 2024

🎉 This issue has been resolved in version 0.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants