Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: manual users provisioning #40

Merged
merged 12 commits into from
Oct 14, 2024
Merged

feat: manual users provisioning #40

merged 12 commits into from
Oct 14, 2024

Conversation

mfiedorowicz
Copy link
Member

@mfiedorowicz mfiedorowicz commented Oct 8, 2024 •
edited
Loading

  • disable auto provisioning of diode users via migrations (with auto_provision_users plugin config setting)
  • detect missing diode users and redirect user to plugin setup view with a form composed of pre-defined or generated API keys for diode users, create missing users and api keys on submit

@mfiedorowicz
feat: disable users auto provisioning with migration
717e627 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
python fmt
be108dc 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
rename user category to user type
dd0a0d5 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
feat: add setup form
50e5256 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
test for plugin config helpers
bd3a9a8 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
feat: add setup view
ad02aeb 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz mfiedorowicz self-assigned this Oct 8, 2024
@github-actions github-actions bot added the python label Oct 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1734 1715 99% 0% 🟢

New Files

File Coverage Status
netbox_diode_plugin/tests/test_plugin_config.py 100% 🟢
TOTAL 100% 🟢

Modified Files

File Coverage Status
netbox_diode_plugin/init.py 100% 🟢
netbox_diode_plugin/forms.py 100% 🟢
netbox_diode_plugin/plugin_config.py 100% 🟢
netbox_diode_plugin/tests/test_forms.py 100% 🟢
netbox_diode_plugin/tests/test_views.py 100% 🟢
netbox_diode_plugin/urls.py 100% 🟢
netbox_diode_plugin/views.py 98% 🟢
TOTAL 100% 🟢

updated for commit: 085c641 by action🐍

leoparente
leoparente approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@leoparente leoparente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfiedorowicz
update README
df20fe0 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
add setup warning alert
9f7551d 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
update setup warning copy
b5aa9b5 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
typo
faeb8ab 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz
refine setup view copy
085c641 
Signed-off-by: Michal Fiedorowicz <[email protected]>
@mfiedorowicz mfiedorowicz changed the title feat: manual provisioning users feat: manual users provisioning Oct 14, 2024
@mfiedorowicz mfiedorowicz merged commit 962e2d5 into develop Oct 14, 2024
5 checks passed
@mfiedorowicz mfiedorowicz deleted the manual-users-provisioning branch October 14, 2024 14:27
@orb-ci
Copy link

orb-ci commented Oct 14, 2024

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoparente leoparente leoparente approved these changes

Assignees

@mfiedorowicz mfiedorowicz

Labels
markdown python released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfiedorowicz @orb-ci @leoparente