Fixes: #18353 - Don't cache CACHE_KEY_CATALOG_ERROR if ISOLATED_DEPLOYMENT is True #18371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
approved these changes
Jan 9, 2025
jeremystretch
deleted the
18353-dont-cache-plugin-catalog-error-isolated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18353
Skips caching the result of an errored call to
get_catalog_pluginsifISOLATED_DEPLOYMENT == True. This call to the catalog API already has a short-circuit which returns{}and skips making the API call ifISOLATED_DEPLOYMENTis True; this change makes it so that the error popup does not appear and the errored result is not cached so that if the setting is turned off, the API call attempt will occur again right away.