-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Html label design: Vector font, flexible label design, preview and print result 1:1 and more #84
base: master
Are you sure you want to change the base?
Conversation
ACK. Hi lhbl, give me a few days to run some tests on this :)
…On Thu, 15 Aug 2024, 17:01 LHBL2003, ***@***.***> wrote:
@LHBL2003 <https://github.com/LHBL2003> requested your review on: #84
<#84> Html label
design: Vector font, flexible label design, preview and print result 1:1
and more as a code owner.
—
Reply to this email directly, view it on GitHub
<#84 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKJY354WHMFDH776FVUAYDZRTGFLAVCNFSM6AAAAABMSOWSJ2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTHA4TQMJVHEYTOOA>
.
You are receiving this because your review was requested.Message ID:
***@***.***
com>
|
…as taken over from the old code, but no longer fitted properly.
…cal). Supports the Pugin netbox-inventory (https://github.com/ArnesSI/netbox-inventory)
… (Default Black). Otherwise the font turns gray.
I wanted to ask again if there is time and interest to implement such extensions as the two I suggested? I know you all have a lot to do, but what's not fun is when someone invests a lot of time and the project fails. I'm thinking back to this project where he went to extreme lengths, including a YouTube video: master...Jasonlin1198:netbox-qrcode:master https://youtu.be/dtXzdX3FLoA?si=Ptje7KE4KETlPHYM If you would like to keep the netbox-qrcode plugin very small like in the last years, please let me know. Because in the meantime I'm thinking about creating my own plugin version on this basis, e.g. Netbox-LabelPrint. Then you would have a mini version like this and something that might evolve into something bigger. Don't be mad at me, but I would like to know where the journey is going. Before my suggestion ends up like Jasonlin1198's :-) |
hi @LHBL2003 priority is to push a v4.1 release out there (0.0.15) (alongside work through the deprecated lib and netbox v4.0.11 - 0.0.14) - this PR is not forgotten and yes we want to do far more with this - however in general we prefer 1 PR for 1 issue - whereas this is a number of changes hence it makes things very difficult to review seeing what section is solving what (even more so with loads of comments on existing code). This really needs to be introduced in a more granular fashion so its easier on users and to review. How amenable are you to splitting this up to smaller PR's per issue ? - also I'd maybe leave logo till last, not sure I'm keen on large b64 encode things in config files, but things like multi-page, alignment etc we definitely want to do (and give you credit if you've done the work) |
Hi @cruse1977, glad to hear it. My goal with this PR was just to get the font crisp. Because scaling the text as an image always made it pixelated and ugly on the print. :) For this reason, I made sure that this only happens in HTML, as you can specify millimeters or inches for the font here. This “vector” based solution ensures that the font remains of high quality. Because in Python it was impossible to get a high quality (I tried again and again for months). Since two images had previously been assembled via Python, I could no longer use this principle. So I had to move the alignment of the objects, which was previously done in Python, to HTML. So in this PR I tried not to destroy the parameters. And that all parameters continue to work. Only after I was finished did I look at which issues could be marked as solved. Since these were rather side effects of the conversion. So it was not the intention to close issues. Separating them into separate pull requests is therefore hardly possible, if at all, because they are all positive side effects of the conversion. Question 1: Question 2: |
I hope that this pull request will help many people.
The following issues and pull requests are covered.
Pull
#62
Issues
#73
#66
#43
#35
#33
#32
#82 (At least plugin netbox-inventory)
Fork
Link to my Fork Projekt: Klick HERE
Pull Request overview
Here are some improvements (if I haven't forgotten anything :D )
@ALL and @cruse1977: I look forward to your feedback.
How to install the plugin for testing:
More info about "How to install in forked plugin" Klick HERE
To reinstall the current release plugin:
Documentation of my branch version:
The following things are described here.
To the manual: Klick HERE
All translations are from German to English. :)
But it's the will that counts.