NetBox 4.x Full PR #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natm
reviewed
Jun 7, 2024
natm
reviewed
Jun 7, 2024
natm
reviewed
Jun 7, 2024
natm
approved these changes
Jun 7, 2024
jeffgdotorg
reviewed
Jun 7, 2024
| @@ -48,16 +48,6 @@ Restart NetBox and add `netbox-floorplan-plugin` to your local_requirements.txt | |||
|
|
|||
| See [NetBox Documentation](https://docs.netbox.dev/en/stable/plugins/#installing-plugins) for details | |||
|
|
|||
| ## Contributors ## | |||
There was a problem hiding this comment.
What's the rationale for removing this section?
| ``` | ||
| source /opt/netbox/venv/bin/activate |
There was a problem hiding this comment.
I tend to favor leaving all necessary instructions in place to up the odds of success for someone installing this plugin as their first plugin. If the deletion is about the pathname being possibly invalid, I think we can go with ${NETBOX_HOME}/venv/bin/activate or similar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes