Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xmlsec1 for django3-auth-saml2 #1283

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tim-schneider
Copy link

@tim-schneider tim-schneider commented Aug 7, 2024

Related Issue: None

New Behavior

Extends requirements to enable the use of SAML SSO Providers via django3-auth-saml2.

As #876 has already introduced other libraries for Python Social Auth.

Contrast to Current Behavior

Currently these dependencies aren't included, meaning users can't take advantage of SAMLSSO by django3-auth-saml2 unless they create their own image.

Discussion: Benefits and Drawbacks

  • Benefit: Enabling users to use functionality included in Netbox without needing to create bespoke images and SAML is more use than OICD in the enterprise world.
  • Drawback: Additional dependencies increase the image size, and the version pinning will need to be periodically reviewed.
  • Backwards-compatible: Yes

Changes to the Wiki

None

Proposed Release Note Entry

Requirements needed to use SAML SSO Providers via django3-auth-saml2 have been added

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@cimnine
Copy link
Collaborator

cimnine commented Aug 7, 2024

libxmlsec is already there in the list, isn't that enough?

@tim-schneider
Copy link
Author

libxmlsec is already there in the list, isn't that enough?

Sadly not :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants