-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add some "extras" tests to exercise the schema a bit more #447
Conversation
f26bc1a
to
e258cfa
Compare
0e5e999
to
a9453e1
Compare
992c015
to
bfeb26b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👌
One note though, every values.yaml
in this ci/
folder adds another ~8 min of for install CI run, and x3 times more on the upgrade CI run.
Might be reasonable to merge this one with an already existing one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, actually after re-reading it, I cannot work in the way it is.
See my inline comments.
- configMap: | ||
name: extraconfig-cm | ||
items: [] | ||
optional: true | ||
- secret: | ||
name: extraconfig-secret | ||
secretName: "not so secret" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation was wrong, and I fixed in a previous commit.
Now the actual values/properties are used, and it fails: the mentioned configMap and secret must exist to be referenced and used.
To do this test, we'd need to define extra template with the named configMap and secret.
See
netbox-chart/charts/netbox/templates/_helpers.tpl
Lines 123 to 129 in a132127
{{- else if $config.configMap }} | |
configMap: | |
{{- include "common.tplvalues.render" (dict "value" $config.configMap "context" $) | nindent 4 }} | |
{{- else if $config.secret }} | |
secret: | |
{{- include "common.tplvalues.render" (dict "value" $config.secret "context" $) | nindent 4 }} | |
{{- end }} |
The templating can probably be improved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, after figuring out what was wrong in my chart, I'm inclined to just drop this for now. Rye indentation was prettier being a jerk I think?
We should probably have a big values yaml that exercises as much of the chart as possible, given how much time it adds.
No description provided.