-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve database client options templating #439
Improve database client options templating #439
Conversation
Thanks for submitting this pull request, @joachimBurket. It would be something like that: OPTIONS: {{- include "common.tplvalues.render" (dict "value" .Values.externalDatabase.options "context" $) | nindent 8 }} What do you think? |
@LeoColomb yeah, I like this; should be pretty easy to implement and avoids a TON of boilerplate on the user's part |
and allows you to decide how to set |
Sorry for the delay, I haven't seen the notification. Yes this seems a way better idea! 👍 |
sslrootcert
option57918a3
to
fc2b6ab
Compare
6cd2377
to
06df5bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I've also added this to our 5.0.0 release notes WIP:
* The `externalDatabase.sslMode` setting has been removed and replaced by an `options` map that can take an arbitrary list of extra PostgreSQL options.
The
sslrootcert
parameter specifies the name of a file containing SSL certificate authority (CA) certificate(s). If the file exists, the server's certificate will be verified to be signed by one of these authorities (in the case of an SSL connection to the PostgreSQL DB).See the option in the documentation here: https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNECT-SSLROOTCERT
Resolves #417