Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init NetBox Operator Helm chart #397

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Init NetBox Operator Helm chart #397

merged 3 commits into from
Dec 18, 2024

Conversation

LeoColomb
Copy link
Member

@LeoColomb LeoColomb commented Oct 25, 2024

This PR implements a Helm chart for the NetBox Operator.

Resolves netbox-community/netbox-operator#105

Tasks

Preview Give feedback

@LeoColomb
Copy link
Member Author

Thanks for your review, @jstudler!
Indeed, just switched to an empty default so it can use the upstream value.

While I think I'm mostly done with the chart, I struggle to set up a correct CI environment.
Having a NetBox automatically configured with restorationHashFieldName custom field seems difficult to automate.
Do you have an instance available for test somewhere? If not, do you have a way to automate?

@LeoColomb LeoColomb marked this pull request as ready for review November 11, 2024 17:24
@jstudler
Copy link

jstudler commented Dec 3, 2024

For automated deployment on a local kind cluster you can use make create-kind && make deploy-kind from https://github.com/netbox-community/netbox-operator/blob/main/Makefile

We currently just load a SQL file to the database (see https://github.com/netbox-community/netbox-operator/blob/main/kind/load-data-job/local-demo-data.sql#L3)

@LeoColomb
Copy link
Member Author

Thanks for the input @jstudler.
That's nothing we can easily do in the Helm chart testing CI, I'm afraid…
But all fine, I guess a NetBox Cloud tiny instance would do the trick. 😊

Copy link

@jstudler jstudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested this, looks good to me!

Copy link
Contributor

@RangerRick RangerRick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do it

@LeoColomb LeoColomb merged commit 803686c into develop Dec 18, 2024
19 checks passed
@LeoColomb LeoColomb deleted the leo/feat/operator branch December 18, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy with a Helm chart
3 participants