Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new Device Types for AVM, Dell and Sophos #2336

Merged
merged 14 commits into from
Nov 6, 2024

Conversation

VentByte
Copy link
Contributor

AVM:

  • Fritz!Box 7510

Dell:

  • PowerSwitch N3248P-ON
  • PowerSwitch S4128F-ON

Sophos:

  • AP6 420E
  • APX320
  • APX530
  • XGS 126
  • XGS 126

device-types/AVM/FRITZBox-7510.yaml Outdated Show resolved Hide resolved
device-types/Dell/PowerSwitch-N3248P-ON.yaml Show resolved Hide resolved
device-types/Dell/PowerSwitch-N3248P-ON.yaml Show resolved Hide resolved
device-types/Dell/PowerSwitch-S4128F-ON.yaml Outdated Show resolved Hide resolved
@harryajc harryajc added the status: revisions needed This issue requires additional information to be actionable label Oct 22, 2024
@danner26 danner26 marked this pull request as draft October 28, 2024 23:59
@VentByte VentByte requested a review from harryajc November 4, 2024 18:21
@VentByte VentByte marked this pull request as ready for review November 4, 2024 18:21
harryajc
harryajc previously approved these changes Nov 5, 2024
@harryajc
Copy link
Collaborator

harryajc commented Nov 5, 2024

Hi @VentByte

Thank you for making the requested changes, However there appears to be some merge conflicts with this PR. Please can you resolve these issues so that this PR can be merged

@VentByte
Copy link
Contributor Author

VentByte commented Nov 5, 2024

Hi @harryajc
I've resolved the merge conflict, so the PR should now be ready to merge now.

@harryajc harryajc merged commit 5c1568b into netbox-community:master Nov 6, 2024
3 checks passed
Floppe pushed a commit to Floppe/devicetype-library that referenced this pull request Nov 12, 2024
* Added Dell PowerSwitch N3248P-ON and S4128F-ON

* Added Sophos XGS 126 and 136

* Added Sophos AP6-420E, APX320 and APX530

* Added Fritzbox 7510

* fixed duplicate device type naming

* Removed non-existing LAN Ports

* Moved Power-Ports to seperate module, Add type and mode to POE ports

* Add module-type definition and image for Dell 1150W hot swap psu

* [DELL S4128F-ON] changed power-ports to module-bay and added module-type for psu

* added missing newlines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: revisions needed This issue requires additional information to be actionable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants