-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new Device Types for AVM, Dell and Sophos #2336
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sophos-xgs' into develop
harryajc
requested changes
Oct 22, 2024
harryajc
added
the
status: revisions needed
This issue requires additional information to be actionable
label
Oct 22, 2024
harryajc
previously approved these changes
Nov 5, 2024
Hi @VentByte Thank you for making the requested changes, However there appears to be some merge conflicts with this PR. Please can you resolve these issues so that this PR can be merged |
…ns for sophos definitions.
Hi @harryajc |
harryajc
approved these changes
Nov 6, 2024
Floppe
pushed a commit
to Floppe/devicetype-library
that referenced
this pull request
Nov 12, 2024
* Added Dell PowerSwitch N3248P-ON and S4128F-ON * Added Sophos XGS 126 and 136 * Added Sophos AP6-420E, APX320 and APX530 * Added Fritzbox 7510 * fixed duplicate device type naming * Removed non-existing LAN Ports * Moved Power-Ports to seperate module, Add type and mode to POE ports * Add module-type definition and image for Dell 1150W hot swap psu * [DELL S4128F-ON] changed power-ports to module-bay and added module-type for psu * added missing newlines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVM:
Dell:
Sophos: