Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the uploading of front_image and rear_image for device types #85

Closed
wants to merge 1 commit into from
Closed

Fix the uploading of front_image and rear_image for device types #85

wants to merge 1 commit into from

Conversation

jbemmel
Copy link
Contributor

@jbemmel jbemmel commented Mar 17, 2023

Addresses #84

@danner26
Copy link
Member

Hello @jbemmel, as mentioned in the pre-release notice, v2.0.0 was released today. The DeviceType Library Import script has been updated to version 2, bringing performance improvements, enhanced logging, and other upgrades. We have bumped the release by a major version due to the significant changes to the codebase.

Thus, you will need to reevaluate how your PR is written and what files have been modified. I would be glad to assist if needed.

@danner26 danner26 added the status: revisions needed This issue requires additional information to be actionable label Mar 24, 2023
@jbemmel
Copy link
Contributor Author

jbemmel commented Mar 28, 2023

See #91 for new PR

@jbemmel jbemmel closed this Mar 28, 2023
@jbemmel jbemmel deleted the fix_image_upload branch March 28, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: revisions needed This issue requires additional information to be actionable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbemmel @danner26