Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial support for case type selection #2208
base: master
Are you sure you want to change the base?
feat: initial support for case type selection #2208
Changes from 4 commits
4e4668e
f0065ed
bfb061a
d2cc288
3b015b2
40c5032
9235d0d
0eef7e9
33301f4
b59ae2e
7592150
5cba7cf
14190bd
3d80b1b
fa607e3
cf1ddf7
50fe8b2
35c4167
2fce7ec
26f5f06
ee1f782
707dbb1
5b0afbb
7c15944
8cd3da7
2eaf507
9abfe52
1ac1093
a482f79
b4048db
b730e41
e5d57c2
301cf0c
3531cd2
46d1f48
5a5618b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you elaborate here in the code on what this function is supposed to do?
github copilot can help :p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dang, I'm surprised copilot understood immediately the code. I'm starting to question reality :D
Added some JsDoc. Basically this function escapes parenthesis which will then later be removed.
I see here an opportunity to create
@nestjs/utils
or@nestjs/stringUtils
because this code is shared across projects, and I feel it would be beneficial to centralize it so that it's easier to maintain and can be reused by plugin developers. I didn't do it to keep the scope limited, but it shouldn't be too hard to do and I would be up for it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I updated the same code also in
@nestjs/schematics
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.