Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invoice currency check with chain network #273

Merged

Conversation

chenyukang
Copy link
Collaborator

Closes #221

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 44.39%. Comparing base (a18a73b) to head (87192a8).

Files with missing lines Patch % Lines
src/rpc/invoice.rs 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
- Coverage   44.42%   44.39%   -0.03%     
==========================================
  Files          44       44              
  Lines       28095    28112      +17     
==========================================
  Hits        12480    12480              
- Misses      15615    15632      +17     
Flag Coverage Δ
unittests 44.39% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quake quake merged commit 0a6b11e into nervosnetwork:main Oct 30, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PRC: Missing Currency Validation in new_invoice
3 participants