Add mix discovery command for device discovery #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses :mndp library and delegates to mix mndp.discover. If we switch discovery method over time this means we can fairly easily switch without changing the command. It requires MNDP to be running in your app and a matching change to mix nerves.new might be reasonable to include mndp.
lawik
requested review from
fhunleth,
mnishiguchi,
jjcarstens and
ConnorRigby
|
I am not sure we are happy to put this in yet or if mndp needs some time to bake. I really like what it would bring in terms of dev convenience. You run
This doesn't have the risk of collision with system implementations and general weirdness that we get with mDNS. Maybe we will find other weirdness? I don't know. But it seems rad. |
|
nerves_bootstrap PR: nerves-project/nerves_bootstrap#332 |
|
@lawik I really like MNDP, but I think I need to spend some time using this in anger before elevating it to Nerves core tooling. The good part is that everyone can use |
|
Entirely fair. I'm fine with these PRs idling or being closed and we go in for it when it feels ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses :mndp library and delegates to mix mndp.discover. If we switch discovery method over time this means we can fairly easily switch without changing the command.
It requires MNDP to be running in your app and a matching change to mix nerves.new might be reasonable to include mndp.