Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec pointer to have better support for omit empty #7

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Spec pointer to have better support for omit empty #7

wants to merge 5 commits into from

Conversation

henderiw
Copy link
Contributor

@henderiw henderiw commented Apr 4, 2023

using pointer for empty values instead of using default go values.

@nephio-prow nephio-prow bot requested a review from johnbelamaric April 4, 2023 18:02
@nephio-prow
Copy link
Contributor

nephio-prow bot commented Apr 4, 2023

Hi @henderiw. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johnbelamaric
Copy link
Member

/ok-to-test

johnbelamaric
johnbelamaric requested changes Apr 13, 2023
View reviewed changes
Copy link
Member

@johnbelamaric johnbelamaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the complete files again, it's hard to review. It would be best if you can rebase so we only see the pointer changes

hack/boilerplate.go.txt Outdated Show resolved Hide resolved
nf_requirements/v1alpha1/capacity_interfaces.go Outdated Show resolved Hide resolved
@gvbalaji
Copy link

Looks like a rebase is needed

@henderiw henderiw closed this Apr 25, 2023
@nephio-prow nephio-prow bot removed the approved label Apr 25, 2023
@henderiw henderiw reopened this Apr 25, 2023
@nephio-prow
Copy link
Contributor

nephio-prow bot commented Apr 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: henderiw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@nephio-prow
Copy link
Contributor

nephio-prow bot commented Apr 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: henderiw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Apr 25, 2023
@henderiw
Copy link
Contributor Author

/retest

gvbalaji
gvbalaji reviewed Apr 25, 2023
View reviewed changes
Copy link

@gvbalaji gvbalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do away with some of the getters but no harm. Aked a question on MaxNFConnections, other than that
/approve.

nf_requirements/v1alpha1/capacity_types.go Show resolved Hide resolved
@gvbalaji
Copy link

rebase needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvbalaji gvbalaji gvbalaji left review comments

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

Assignees
No one assigned
Labels
approved ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henderiw @johnbelamaric @gvbalaji